feat(cli): added Ctrl+Z (SIGTSTP) support #2836
Conversation
|
I finally remembered to test it from just recipe. Yeah, it doesn't work like that. Or rather, I have to press Ctrl+Z twice. I think, once to suspend I can try another approach, which basically means remove the root cause instead of making a workaround. |
|
@jkelleyrtp, ready for initial review, thoughts, verdict. Still has some debugging stuff. |
|
Hey - I'm cleaning up the PR list and this got clobbered by a bunch of changes we made regarding the CLI. Feel free to re-open this if you want. Definitely give the new CLI a test drive first though, since this might be fixed with the new render code. |
Sure! But did you know that a regular user can't re-open if someone with write permissions/member/owner has closed the PR (or issue)? So this means that you need to re-open it for me if I want it. |
|
I tried the new CLI, and it still doesn't support terminal stop signal. :( |
Fixes one entry from #2788 (comment) by adding support for Ctrl+Z. I did face a few problems. But overall it works.
It adds
(signal)to the zsh's suspend job log message, which isn't there when SIGTSTP is used in other programs. Another thing is that when it is stopped in the middle of some building process (at least during Wasm shenanigans) it can ruin the build (with a panic message) and thedx servemust be restarted. This should be explored more because suspending shouldn't break anything ideally.The quirk that is interesting is where the execution is continued. This is nice to know as I used a condition check in the main loop before and didn't understand why no logs from it showed up. The less code, the cleaner it gets!
It looks like there is only 1 new package according to
Cargo.lock. Nice.I added a few notes in different places. Like using private field from
screenvariable isn't great.